LeDragoX / Win-Debloat-Tools

Re-imagining Windows like a minimal OS install, already debloated with minimal impact for most functionality.
MIT License
4.79k stars 245 forks source link

Remove ShutUp10 #167

Open nemchik opened 1 month ago

nemchik commented 1 month ago

Description

ShutUp10 seems great as a tool to use manually, maybe after running this script, but it's insanely unintuitive to try and decipher what all the config options in https://github.com/LeDragoX/Win-Debloat-Tools/blob/main/src/configs/shutup10/ooshutup10.cfg and https://github.com/LeDragoX/Win-Debloat-Tools/blob/main/src/configs/shutup10/ooshutup10-default.cfg are.

There also seem to be conflicting configurations between ShutUp10 and your personal tweaks script. https://github.com/LeDragoX/Win-Debloat-Tools/blob/d43f8b7511041d2db60d9d79b40034e1c2be45a7/src/scripts/Register-PersonalTweaksList.ps1#L236-L242 This should allow these two settings to be user configurable image However since the config has these two lines https://github.com/LeDragoX/Win-Debloat-Tools/blob/d43f8b7511041d2db60d9d79b40034e1c2be45a7/src/configs/shutup10/ooshutup10.cfg#L115 and https://github.com/LeDragoX/Win-Debloat-Tools/blob/d43f8b7511041d2db60d9d79b40034e1c2be45a7/src/configs/shutup10/ooshutup10.cfg#L117 These apply the settings to HKLM while your tweaks only remove the entries in HKCU.

Just for visibility, you also have https://github.com/LeDragoX/Win-Debloat-Tools/blob/d43f8b7511041d2db60d9d79b40034e1c2be45a7/src/configs/shutup10/ooshutup10.cfg#L114 and https://github.com/LeDragoX/Win-Debloat-Tools/blob/d43f8b7511041d2db60d9d79b40034e1c2be45a7/src/configs/shutup10/ooshutup10.cfg#L116 which are the HKCU entries that your tweaks script later removes.

As you might have guessed, deciphering which config options in ShutUp10 are which was a bit of a chore, and it's much easier to look through the rest of your script to see exactly what's going on.

I don't know if there are things in ShutUp10 that you really like that would be a pain to implement directly in your scripts, but if not I personally think it would be great to remove ShutUp10 entirely and implement anything it was covering (if your scripts don't already do so).

Reason

Explanation provided above regarding reasoning. tldr; ShutUp10 config is cryptic and it's not easy to see what the config does compared to almost everything else in the script being very easy to see what's being changed

Examples

No response

entauri commented 1 month ago

Partially related, but if I'm already using oo shutup (and simplewall) before running this script do I have to restore everything default?