LeHubca / lehub-website

Website for lehub.ca
Other
0 stars 1 forks source link

updating offerings / offres dropdown menu to link to secondary pages #11

Closed tliacas closed 6 months ago

tliacas commented 6 months ago

We'd like to update the dropdown menu item called offerings (EN), offres (FR) to link to three separate pages

WORKSHOPS - would link to this page currently called Offerings but would be renamed Workshops: https://www.lehub.ca/en/offerings/ to be renamed https://www.lehub.ca/en/workshops/ (EN) https://www.lehub.ca/fr/ateliers/

WIKI - (EN) would link to https://en.wiki.lehub.ca/index.php/Main_Page, (FR) would link to: https://fr.wiki.lehub.ca/index.php/Accueil

REPORTS - Would link to secondary page still to be created - EN https://www.lehub.ca/en/reports/ FR https://www.lehub.ca/fr/rapports/

alberto56 commented 6 months ago

Some questions before I start:

  1. https://www.lehub.ca/en/workshops/ already exists, please confirm that page would disappear
  2. https://www.lehub.ca/en/reports/ and https://www.lehub.ca/fr/rapports/ still to be created: should I leave it out for now, or do you want to wait to create those pages before making this change to the menu?
tliacas commented 6 months ago

Hi Albert, I have updated and published https://www.lehub.ca/en/workshops/ and FR https://www.lehub.ca/fr/formations/ but they do not seem to be live for some reason even though I pubbed yesterday

Also, I created https://www.lehub.ca/en/reports/ and https://www.lehub.ca/fr/rapports/ and same thing, not visible though created yesterday

alberto56 commented 6 months ago

OK, I will check.

tliacas commented 6 months ago

Looks like those pages are working now! Is it ok to continue editing them?

alberto56 commented 6 months ago

Yup, I fixed 'em.

It's because you set the paths as /workshops/, /formations/, etc, instead of /en/workshops/, /fr/formations/, etc. (The language code is not automatically added, you need to add it yourself, it's just a convention)

Screenshot 2024-05-09 at 09 47 31

I fixed it, so it's all good. I also changed the example to be more explicit:

Screenshot 2024-05-09 at 09 51 20

The rest should be OK, please advise if you need adjustments:

tliacas commented 6 months ago

Hey Albert thanks for the quick work, much appreciated!

It all looks good on desktop and mobile to me now.

T

Sent with Proton Mail secure email.

On Thursday, May 9th, 2024 at 10:40 AM, Albert Albala @.***> wrote:

Yup, I fixed 'em.

It's because you set the paths as /workshops/, /formations/, etc, instead of /en/workshops/, /fr/formations/, etc. (The language code is not automatically added, you need to add it yourself, it's just a convention)

Screenshot.2024-05-09.at.09.47.31.jpg (view on web)

I fixed it, so it's all good. I also changed the example to be more explicit:

Screenshot.2024-05-09.at.09.51.20.jpg (view on web)

The rest should be OK, please advise if you need adjustments:

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

tliacas commented 6 months ago

Oh I did not answer your questions about deactivating Offerings - Offres on desktop... yeah it would be good to remove the link and make only dropdown items clickable!

alberto56 commented 6 months ago

Oh I did not answer your questions about deactivating Offerings - Offres on desktop... yeah it would be good to remove the link and make only dropdown items clickable!

OK done! Let me know if you need anything else!

alberto56 commented 6 months ago

I'll close this ticket, just reopen it if you need anything else.