search

LeMonADE-project / LeMonADE

Library for Monte Carlo Simulation applying the Bond Fluctuation Model
Other
3 stars 11 forks source link

Protect master branch? #10

Closed MartinWenge closed 8 years ago

MartinWenge commented 8 years ago

Protecting the master branch would force us to create a pull request for every merge and disables a forced merge. If we protect this branch we can modify the settings defining what is necessary to accept a pull request.

hrabbel commented 8 years ago

Should definitely be done to my opinion. The master branch should be guaranteed to be as stable as possible, thus review by others before merging into it makes perfect sense.

MartinWenge commented 8 years ago

Master branch is protected now. Should we add status checks (https://developer.github.com/v3/repos/statuses/) to control every commit? Or is this too much effort?

hrabbel commented 8 years ago

Not sure. Of course it can be useful, but I feel like it might be too much effort. Other opinions?

Bondoki commented 8 years ago

I agree and we already protect the master branch. We can close this issue.