LeMonADE-project / LeMonADE

Library for Monte Carlo Simulation applying the Bond Fluctuation Model
Other
3 stars 11 forks source link

Min image convention #102

Closed tonimueller closed 5 years ago

MartinWenge commented 5 years ago

Should the Power Of Two Box specialization check if the box sizes are valid?

tonimueller commented 5 years ago

There should be a check for the power of two and for the periodicity.

MartinWenge commented 5 years ago

The functions are only valid for full periodic boundaries now, should we split this for systems with mixed periodic boundaries?

MartinWenge commented 5 years ago

The current implementation seems to do the job. We could do some cleanup of the comments or take it as it is :)