search

LeMonADE-project / LeMonADE

Library for Monte Carlo Simulation applying the Bond Fluctuation Model
Other
3 stars 11 forks source link

* changed the output path in cmake #13

Closed Bondoki closed 8 years ago

Bondoki commented 8 years ago
hrabbel commented 8 years ago

I don't quite understand the purpose of the Makefile, to be honest. The one that CMake provides also has the option 'clean'.

Bondoki commented 8 years ago

As above: configure and Makefile in the root directory are "convient files" for easy installation. I wanted to avoid "mkdir build; cd build; cmake ..; make" because it's the usual step and can be simplified. But anyway we can delete them - it's just an suggestion. We can stick with "mkdir build; cd build; cmake ..; make"

hrabbel commented 8 years ago

Can we make a new branch like feature-cmakeStructure or the like, and you re-submit the pull request there? Then we merge it into that branch and can make some more changes.

I find the idea nice, but I have some changes to suggest (which I already implemented, more or less), which I don't know how to do here properly. Changes go into the direction of: -not providing a wrapper Makefile, but let the configure script create one (like suggested in the discussion) -constructing the structure such that there is a build directory, which can be set when calling the configure scipt -DBUILDDIR_LEMONADE -there is a separate install path, which can be set as suggested here, but will only be used if you call 'make install'. CMake provides the structures for this

I have already implemented these suggested changes, but I think it would be easier to follow the changes in a separate branch.

Bondoki commented 8 years ago

No problem. I also rewrite the cmake commands, but anyway we can reject this pull request or you can merge it with your changes:

Step 1: From your project repository, check out a new branch and test the changes. git checkout -b Bondoki-develop develop git pull https://github.com/Bondoki/LeMonADE.git develop

Step 2: Merge the changes and update on GitHub.

git checkout develop git merge --no-ff Bondoki-develop git push origin develop

hrabbel commented 8 years ago

Ok, I'm closing this and open a new one based on the suggestions made here.