Open Bondoki opened 7 years ago
The AddMonomer function in Molecules:
template < class CoordinateType > uint32_t addMonomer(const CoordinateType& x, const CoordinateType& y, const CoordinateType& z) { vertex_type monomer; monomer.setX(x); monomer.setY(y); monomer.setZ(z); vertices.push_back(monomer); return (vertices.size()-1); }
has two problems:
const CoordinateType&
vertex_type
Vector3D
There is already a more general implementation
uint32_t addMonomer(vertex_type monomer) { vertices.push_back(monomer); return (vertices.size()-1); }
What shall we do? Delete the first implementation? Or at least rewrite it?
The AddMonomer function in Molecules:
has two problems:
const CoordinateType&
isn't necessary -> simple copy is sufficientvertex_type
has implicit the functionality ofVector3D
There is already a more general implementation
What shall we do? Delete the first implementation? Or at least rewrite it?