search

LeMyst / WikibaseIntegrator

A Python module to manipulate data on a Wikibase instance (like Wikidata) through the MediaWiki Wikibase API and the Wikibase SPARQL endpoint.
MIT License
67 stars 17 forks source link

Moving extra datatypes to be added to BaseDatatype subclasses. #799

Closed sammasak closed 4 days ago

sammasak commented 5 days ago

This change adds the extra datatypes into the BaseDatatype subclasses list and solves the index out of range issue #798

Couldnt find where to add the datatypes so they get added to the BaseDatatype subclasses, but adding them in the datatypes init file added them. Please point in the right direction.

lucassmed commented 5 days ago

Hi @LeMyst

Lucas here! My colleague has issued a PR above to make a small change to the lib to fix some critical issues that is causing an issue with some internal workflows.

Basically, when we try use the lib to fetch items that have statements which have datatypes such as mediafile we get errors back and PR aims to fix that.

If you have any questions please let us know, we are keen to help in any way possible!

LeMyst commented 5 days ago

Hello @sammasak and @lucassmed , Thank you for your issue/PR, it's a case that I never encountered because I don't use these extensions.

I've made some aesthetic changes and added a unit test to avoid having the issue appear again.

Gonna merge this later and probably release a new patch version.

Thank you again

lucassmed commented 5 days ago

@LeMyst legend thank you so much!