search

LeNomDesFleurs / NOI-VCVRACK

Modules for VCV Rack
https://library.vcvrack.com/NOI
GNU General Public License v3.0
7 stars 0 forks source link

Integration issues #1

Closed cschol closed 1 year ago

cschol commented 1 year ago

There are a few issues that need to be resolved before integration in the VCV library can continue:

  1. Fix module tags and license. The module is open-souce, so it should have the appropriate open-source license.
[NOI-VCVRACK] Validating plugin.json...FAILED
[NOI-VCVRACK] Issues found in `plugin.json`:        
                                                                                                                                                                                                                                                                                                                      Wilt: invalid module tags: Multi-Effect                                                                                                                                                                                                                                                                               
-- Valid tags are defined in https://raw.githubusercontent.com/VCVRack/Rack/v2/src/tag.cpp                                                                                                                                                                                                                            Invalid license ID: proprietary                                                                                                                            
-- License must be a valid Identifier from https://spdx.org/licenses/
  1. Build failure when cross-compiling on macOS platform:
x86_64-apple-darwin20.2-clang++-libc++  -std=c++11 -stdlib=libc++   -fPIC -I/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include -I/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/dep/include -MMD -MP -g -O3 -funsafe-math-optimizations -fno-omit-frame-pointer -Wall -Wextra -Wno-unused-parameter -DARCH
_X64 -march=nehalem -DARCH_MAC -mmacosx-version-min=10.9  -c -o build/src/Sunflower.cpp.o src/Sunflower.cpp
src/Sunflower.cpp:155:30: error: no member named 'clip' in namespace 'noi::Outils'; did you mean 'clamp'?        
                outputs[OUTPUT].setVoltage(noi::Outils::clip(output, -5.f, 5.f));
                                           ^~~~~~~~~~~~~~~~~                                                                                               
                                           clamp                
/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/math.hpp:32:12: note: 'clamp' declared here
inline int clamp(int x, int a, int b) {                   
           ^                 
src/Sinensis.cpp:124:34: error: no matching function for call to 'Clip'                                                                                    
                outputs[MIX_OUTPUT].setVoltage(noi::Outils::Clip(output, -5.f, 5.f));    
                                               ^~~~~~~~~~~~~~~~~                                                                                           
src/outils.hpp:28:15: note: candidate template ignored: could not match 'T *' against 'float'                                       
                inline void Clip(T* value, T min, T max) {
                            ^  
src/Sinensis.cpp:124:34: error: cannot initialize a parameter of type 'float' with an rvalue of type 'void'
                outputs[MIX_OUTPUT].setVoltage(noi::Outils::Clip(output, -5.f, 5.f));
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/engine/Port.hpp:43:24: note: passing argument to parameter 'voltage' here
        void setVoltage(float voltage, int channel = 0) {                                                                                                  
                              ^
1 error generated.     
In file included from src/Sinensis.cpp:2:                                                                                                                  
src/filter.hpp:21:9: warning: private field 'm_b1' is not used [-Wunused-private-field]
                float m_b1;
                      ^                                                                                                                                    
src/filter.hpp:93:9: warning: private field 'm_Fe' is not used [-Wunused-private-field]
                float m_Fe;
                      ^                                                                                                                                    
src/Sinensis.cpp:10:8: warning: private field 'test_output' is not used [-Wunused-private-field]
        float test_output;
              ^                                                                                                                                            
src/Sinensis.cpp:13:17: warning: private field 'Q_cv' is not used [-Wunused-private-field]
        float freq_cv, Q_cv, band_cv;
                       ^                                                                                                                                   
src/Sinensis.cpp:13:23: warning: private field 'band_cv' is not used [-Wunused-private-field]
        float freq_cv, Q_cv, band_cv;
                             ^                                                                                                                             
5 warnings and 2 errors generated.
make[2]: *** [/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/compile.mk:87: build/src/Sunflower.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....                                                                                                               
make[2]: *** [/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/compile.mk:87: build/src/Sinensis.cpp.o] Error 1
src/Wilt.cpp:142:34: error: no matching function for call to 'Clip'
                outputs[MIX_OUTPUT].setVoltage(noi::Outils::Clip(rvb_output, -5.f, 5.f));
                                               ^~~~~~~~~~~~~~~~~
src/outils.hpp:28:15: note: candidate template ignored: could not match 'T *' against 'float'
                inline void Clip(T* value, T min, T max) {                                                                                                 
                            ^
src/Wilt.cpp:142:34: error: cannot initialize a parameter of type 'float' with an rvalue of type 'void'
                outputs[MIX_OUTPUT].setVoltage(noi::Outils::Clip(rvb_output, -5.f, 5.f)); 
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LeNomDesFleurs commented 1 year ago

Added licence and tag, replace clip function mith math::clamp Thanks !