LeNomDesFleurs / NOI-VCVRACK

Modules for VCV Rack
https://library.vcvrack.com/NOI
GNU General Public License v3.0
7 stars 0 forks source link

Input to control Dry/Wet #8

Closed IohannRabeson closed 2 months ago

IohannRabeson commented 2 months ago

Hi! It could be great if there were an input available to control the dry/wet parameter.

LeNomDesFleurs commented 2 months ago

Hi! Thanks for reaching me In which module would you like to see this feature ?

IohannRabeson commented 2 months ago

Hi! Yeah sorry about that i forgot to mention it was about Hellebore.

LeNomDesFleurs commented 2 months ago

The knob at the bottom is supposed to be a dry wet haha 😅 I think it got a bit messy with all the delay and filter involved, there is probably some phase issue when the dry and wet signal get mixed

I'll see what I can do, don't hesitate if you have any advice

IohannRabeson commented 2 months ago

I would add an input to control the dry/wet parameter.

On Sun, Jul 28, 2024 at 09:21 Thomas Guillory @.***> wrote:

The knob at the bottom is supposed to be a dry wet haha 😅 I think it got a bit messy with all the delay and filter involved, there is probably some phase issue when the dry and wet signal get mixed

I'll see what I can do, don't hesitate if you have any advice

— Reply to this email directly, view it on GitHub https://github.com/LeNomDesFleurs/NOI-VCVRACK/issues/8#issuecomment-2254517635, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHJDEG7MN2QWS2BDPDIXDZOTV6JAVCNFSM6AAAAABLNMYUBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGUYTONRTGU . You are receiving this because you authored the thread.Message ID: @.***>

LeNomDesFleurs commented 2 months ago

Done ! update should be available in a week or so I don't have the space for a cv trimpot, I'll be up to you to scale you cv Modulation is relative, dry wet goes from 0. to 1., the cv adds it's value divided by five. e.g. dry wet = 0.5, cv = -3v 0.5 - (3 / 5) = -0.1 (clipped to 0.0), so full dry I'll close the issue but open up any time if you have more questions