search

LePips / VLCUI

VLCKit for SwiftUI
MIT License
43 stars 18 forks source link

Better Aspect Fill #1

Closed LePips closed 2 years ago

LePips commented 2 years ago

Currently, VLCVideoPlayer.Event.aspectFill animation is manually controlled.

Replace to be more customizable by removing the manual animation and replace with:

enum Event {
    /// Aspect fill given the percentage between 0...1.0
    case aspectFill(Float)
}

This would set the aspect fill state to a certain progress. This would allow gestures to set the aspect fill based on its percentage completed and the send event can be surrounded by an animation for animations.

LePips commented 2 years ago

https://github.com/LePips/VLCUI/commit/71fcc74964882ca790a8bff9507a91ba0970ce5b