LeaPhant / flowabot

Modular Discord bot with fun features including twitch commands and advanced osu! commands. 🌷
MIT License
111 stars 33 forks source link

Possible memory leak #23

Open zivoy opened 5 years ago

zivoy commented 5 years ago

I am running the bot on a GCP instance that has only 600mbs of ram. The bot works for the most part and most things render fine but problems occur when rendering long death streams, the bot uses up all the ram and takes a long time to render. this doesn't happen when rendering normal things like jumps or a regular streams and sliders.

--ziv

LeaPhant commented 5 years ago

Rendering beatmaps just requires a lot of memory. Beatmap Objects can use 100 MB of memory for maps with a lot of objects and that's for every render thread (one per cpu thread) cause I don't think I can share it. I don't know how I can improve this in the future cause Node.js has limited control in this regard and I'm also not well-versed in this kind of optimization.

If you have a specific map where you think there could be a memory leak send it to me, cause I've tested some and memory usage scales with the amount of hit objects.