difficulty bar graph is a bit off

LeaPhant / flowabot

Modular Discord bot with fun features including twitch commands and advanced osu! commands. 🌷

MIT License

111 stars 33 forks source link

difficulty bar graph is a bit off #29

Closed zivoy closed 5 years ago

zivoy commented 5 years ago

This issue is a bit more prominent in shorter maps

Problem: https://github.com/LeaPhant/flowabot/blob/528a5fcd1461c45f715b46e946dd7eb579d1b30b/osu.js#L1633 Solution:

let x = (index + 1) / strain_chunks.length * 399;

LeaPhant commented 5 years ago

Sorry for the late reply, I haven't looked into this project for a while. This totally should be index + 1, you're right. I've never been good with these edge cases. :smile:

Fixed in https://github.com/LeaPhant/flowabot/commit/52ab03c10b05402714935a8698b96d57235f5374, thanks a lot!