LeaPhant / skyblock-stats

A beautiful SkyBlock profile viewer 🌹
https://sky.lea.moe
MIT License
168 stars 33 forks source link

Enchanted Item Overlay #11

Closed FlexXx1212 closed 4 years ago

FlexXx1212 commented 4 years ago

Hey, awesome work, i was actually thinking about doing the same, but a few days later you already did it :)

It would be nice to have any indicator, besides hovering over the item itself, that it is an enchanted item instead of a normal one. (like down below)

For an easy workaround (instead of implementing a real enchanted look) you could also just indicate it with some shiny/purple boarder or something.

image

(ps: i may also contribute to this project when i got some time on my hands)

LeaPhant commented 4 years ago

I tried a lot of different ways over the past days with most of them having performance issues and settled on a canvas solution for now (animated on desktop, static on mobile). I will still try to optimize it further but enchanted items are now distinguishable, although custom heads and gif items don't work (yet?).

ShaunMack commented 4 years ago

Looking pretty good, however not every item is properly highlighted; In particular, Hot Potato Books are not shown enchanted. For reference, check the ender chest of https://sky.lea.moe/stats/LonelyFatKid/Zucchini

LeaPhant commented 4 years ago

Oh, thanks for the hint! By comparing that to other items I think I've finally found a way of reliably checking whether an item is enchanted. If there's any items that are still off please report back.

ShaunMack commented 4 years ago

Looks great! I haven't found any other items that appear incorrectly so far.

EDIT: I guess potions technically should have the enchantment overlay, but that's a matter of style, and it would probably just muddy up the look.

LeaPhant commented 4 years ago

Yeah, potions are still static because I haven't gotten around getting clean icons for them since I used a mod to get all the icon items in high quality which captures the enchantment overlay. Will fix that some other timeâ„¢.