LeaPhant / skyblock-stats

A beautiful SkyBlock profile viewer 🌹
https://sky.lea.moe
MIT License
168 stars 33 forks source link

Skin preview has incorrect pixel #38

Closed Moire9 closed 4 years ago

Moire9 commented 4 years ago

Hello, there's a strange bug with my profile. One of the pixels on my head is incorrect. On the side of my head, there's single red pixel, which is not on my skin. I don't know why this happens, but it's not correct. https://sky.lea.moe/stats/SirNapkin1334/Cucumber

What it looks like: image

What it should look like: image

My skin file for reference: tux

LeaPhant commented 4 years ago

I'm using a third-party site for those 3D skin renders (https://visage.surgeplay.com) and the project is archived so I doubt it'll get fixed on their end. :/

I'll keep this issue open in case I decide to host my own instance and fix it.

nisutec commented 4 years ago

Try this 3D skin render SIte (https://crafatar.com/) It is used also by Hypixel and is up to date.

Moire9 commented 4 years ago

Yes but that site does not show the second layer of the skin. Perhaps we could see what namemc uses?

nisutec commented 4 years ago

It supports the second layer of the skin. Options

Moire9 commented 4 years ago

Oh. However, the overlay is not actually a second layer. It's just shown instead of the other layers. As you can see it's flat image Where it should be textured image

nisutec commented 4 years ago

And @SirNapkin1334 NameMC uses also Crafatar 🙂

LeaPhant commented 4 years ago

I'm not a fan of the flat isometric renders from Crafatar so I'm keeping this for now even if there might be bugs. It would be a lot less visually pleasing if the player skin on the left didn't blend in with the background like it does now.

nisutec commented 4 years ago

Than look at this (https://minerender.org/#skins) it uses crafatar to generate dynamic 3D renders.

LeaPhant commented 4 years ago

I know that project but the site is already pretty resource heavy, I think a client-side 3d renderer would be a bad idea.

LeaPhant commented 4 years ago

Fixed with new skin viewer.