search

LeaVerou / awesomplete

Ultra lightweight, usable, beautiful autocomplete with zero dependencies.
http://leaverou.github.io/awesomplete/
MIT License
6.96k stars 611 forks source link

Add "autocomplete" as initialization option #17159

Closed antoinelyset closed 6 years ago

antoinelyset commented 6 years ago

Hi 👋 !

I have the same issue as #17155, but I suggest a slightly different modification. I don't know if this is a priority but I feared that by modifying the default "autocomplete" value we may break some users' usage (even if this is an undocumented behaviour). Moreover by defaulting to "off" we are still following the best practices.

What do you think ?

And one more question, do I need to update the built/generated files ?

LeaVerou commented 6 years ago

Hey, thanks for submitting a PR!

I wouldn't worry about breaking usage. There doesn't seem to be any use case for having both Awesomplete and the browser's autocomplete. With this, people would need to specify the required value manually, when all they want is to disable the native autocomplete. This is against the UX best practice of sensible defaults.

antoinelyset commented 6 years ago

I understand, should I still keep the possibility to pass another value as an option ?

LeaVerou commented 6 years ago

It seems a little premature to me. We can always add it very easily if even one person requests it, but having a feature with zero use cases seems excessive. Hope that makes sense!

antoinelyset commented 6 years ago

I completely understand (I wanted to set it to "new-address" for a more semantic name). I made the change.

LeaVerou commented 6 years ago

Merged, thanks!