search

LeaVerou / awesomplete

Ultra lightweight, usable, beautiful autocomplete with zero dependencies.
http://leaverou.github.io/awesomplete/
MIT License
6.97k stars 611 forks source link

Add ability to add custom aria-label to the autocomplete listbox and … #17203

Closed heatherpekrul closed 4 years ago

heatherpekrul commented 5 years ago

…default verbiage to fix issue #17200, add documentation to readme regarding options

heatherpekrul commented 5 years ago

Travis is failing and this is what I see in the logs:

0.00s$ sh -e /etc/init.d/xvfb start
sh: 0: Can't open /etc/init.d/xvfb
The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during .
Your build has been stopped.

Running npm test comes back clean so I'm not sure what's going on. I'm happy to amend the PR if you can point me in the right direction.

LeaVerou commented 5 years ago

Hi there,

Thank you for contributing! I have no idea what's wrong with Travis, but I see nothing wrong with your code. The website is the canonical source of documentation, not the README. While I do appreciate you adding that table to the readme, could you please update the website as well?

Thank you!

heatherpekrul commented 5 years ago

Thanks for taking a look, @LeaVerou ! I've updated the website as well.

LeaVerou commented 5 years ago

Hey, sorry for the delay! There are conflicts now, could you resolve them? Thanks!

heatherpekrul commented 5 years ago

@LeaVerou : No worries! I've fixed the conflict.

heatherpekrul commented 4 years ago

@LeaVerou : Just checking in about this PR - is there anything else you'd like me to modify, change, or remove? I'm happy to amend this if there is. We use Awesomplete on a web property that we try to have a high degree of accessibility on, and this missing attribute came up on our report again and I realized I needed to check in.

Thank you!

LeaVerou commented 4 years ago

So sorry for the delay. Looks good to me now, sadly now there are conflicts again. Could you please rebase once more? Thanks!!

heatherpekrul commented 4 years ago

@LeaVerou It's a busy time, I understand. :) I've got the PR updated again. Please let me know if there's anything else you need from me.

LeaVerou commented 4 years ago

Did you push? It still reports conflicts.

heatherpekrul commented 4 years ago

I did push it up - I'm sorry, I must be looking in the wrong place. I see a message that says "This branch has no conflicts with the base branch" so somehow I'm not seeing where the problem is. Can you point me in the right direction? Thank you.

LeaVerou commented 4 years ago

Did you push to the aria-listbox-label-issue-17200 branch? This is what I see here:

image

heatherpekrul commented 4 years ago

@LeaVerou Sorry for the trouble, Lea. I rebased again and got a successful message, so hopefully it's okay now. I fixed two conflicts in README.md and index.html. I pushed it up and I see it in the commits. Fingers crossed... hard to double check when Github is still showing the green light about no conflicts here on the PR :)

LeaVerou commented 4 years ago

I still get the exact same message over here. 😢 Do you get a different one?

heatherpekrul commented 4 years ago

Really not sure what is going awry on my end... I followed the rebase instructions here closely (but with this repo): https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

and I got this message: Successfully rebased and updated refs/heads/aria-listbox-label-issue-17200

Then I pushed it up, and I see the resulting push here. I see a Github message here that says "This branch has no conflicts with the base branch" - I don't see any errors or conflicts. Hopefully this is good now?

Very sorry about the trouble. Thank you for your patience with me - I haven't contributed to very many open source projects.

LeaVerou commented 4 years ago

Now it worked! Merged, thanks!

heatherpekrul commented 4 years ago

Thank you so much!