search

LeaVerou / bliss

Blissful JavaScript
http://blissfuljs.com
MIT License
2.39k stars 101 forks source link

Only set content-type to urlencoded when data is string or URLSearchParams (#208) #210

Closed friday closed 6 years ago

friday commented 6 years ago

As per discussion in #208.

Testing coverage is very limited (changes are semantical more than functional). This is due to sinon.js mock XHR server only supporting strings (This is still the case in the newest version). In other words this PR addresses #208, but not #200. I suggest we leave #200 open, hoping someone else has an idea of how to deal with it. The tests still work (and also would have if I hadn't changed them). They're just lacking coverage.

LeaVerou commented 6 years ago

Thanks!

I suggest we leave the issue open, hoping someone else has an idea of how to deal with it.

So I shouldn't merge this? Or you mean #208?

friday commented 6 years ago

I've clarified the description. This PR addresses #208, but not #200. #200 is loosely speaking the same issue as #208, but focuses on the test specs.

friday commented 6 years ago

Rebased to use $.type() now.