search

LeaVerou / css-almanac

Repo for planning & voting on which stats to study
https://projects.verou.me/mavoice/?repo=leaverou/css-almanac&labels=proposed%20stat
34 stars 3 forks source link

Sizing model JS #47

Closed rviscomi closed 4 years ago

rviscomi commented 4 years ago

Progress on #8

Looking for early feedback to see if I'm using the utils correctly.

LeaVerou commented 4 years ago

Alright, I renamed countProperties to countDeclarationsByProperty to make the distinction more clear.

rviscomi commented 4 years ago

SGTM. Could you also update https://projects.verou.me/rework-utils/ with the new function?

LeaVerou commented 4 years ago

Done!

rviscomi commented 4 years ago

Ah ok yes that makes more sense.

rviscomi commented 4 years ago

FWIW I borrowed the code from 34-named-grid-lines.js which had it all on one line. 😉

LeaVerou commented 4 years ago

Probably because it's shorter, though it would still benefit from some more liberal whitespace :)