search

LeaVerou / css3test

How does your browser score for its CSS3 support?
http://css3test.com
MIT License
214 stars 83 forks source link

Gecko is false negative on @counter-style #185

Closed SebastianZ closed 4 years ago

SebastianZ commented 5 years ago

Firefox does support the @counter-style rule, but the test for it outputs that it doesn't.

Reason for this is that the test creates an empty rule, i.e. @counter-style foo{}, which is ignored. Firefox requires at least one of the descriptors to be defined.

At the time I added a test for this rule in #149 I also filed a bug against Gecko to recognize empty @counter-style rules.

Though such empty at-rules actually don't make much sense and the tests should also check the descriptors at some point or rules that don't have a body like @import, so I suggest to change the check logic to take a complete at-rule instead of just the first part.

Sebastian

LeaVerou commented 5 years ago

Agreed, as long as it's optional.

SebastianZ commented 4 years ago

With #194 merged this is fixed now.

Sebastian