Closed Zefling closed 3 years ago
Or with a modified icon:
The single color icon is much better. I'd also give it a little bit of opacity to visually separate from the text and make the text stand out more.
It's not easy, test all the links one by one. In most cases it's true that it's the same name, but a number of cases it's different.
Didn't you have to test them one by one to put them in tests.js? If so, you already have this data. If not, and you just generated them, you don't need to store them either, you can generate them on the fly!
I passed 3 hours testing them all one by one.
Then we know exactly which ones we can omit, since all of the ones in there now exist :)
Though I'm not sure there's a point in marking any as nonexistent; if a property doesn't have an MDN page today, it may have one tomorrow, and possibly linking to it may encourage that. Note that MDN itself links to nonexistent pages for this very reason.
It would be good to keep the mdn
key for those few instances where there is an MDN page, but it's not possible to automatically generate its URL.
Did you look at https://github.com/mdn/data?
It's available as an npm package.
The data includes links to MDN pages for :
It's interesting, but it also seems complicated to me to implement. What to do with all the exceptions?
Thanks for the commit! It still seems like there's a lot that can be generated though.
Now, these are just the exceptions. It will be easier to follow.
I found a solution to generate more links
Why do we need mdnGroup for media queries? Don't we know whether the feature is a media query?
The 3 firsts tests is not in the group, I create a group for this exception ?
I couldn't find an SVG for the logos, I will draw them.
MDN original logo seems to be here: https://github.com/mdn/mdn-dinocons/blob/master/brands/mdn-dino.svg
Sorry, I see your message too late for the logo. I redraw this. ^^;
@LeaVerou Are you ok with all changes?
Just left a small comment about SVG, apart from that LGTM! Thanks for working on this!
I think all in done now.
Merged, thanks again!!
@TrisTOON I will fix it
Add links documentation: