LeaVerou / css3test

How does your browser score for its CSS3 support?
http://css3test.com
MIT License
214 stars 83 forks source link

Add MDN links #199

Closed Zefling closed 3 years ago

Zefling commented 3 years ago

Add links documentation: Capture d’écran du 2020-10-08 07-08-22

Zefling commented 3 years ago
Zefling commented 3 years ago

Or with a modified icon: Capture d’écran du 2020-10-08 15-00-10

LeaVerou commented 3 years ago

The single color icon is much better. I'd also give it a little bit of opacity to visually separate from the text and make the text stand out more.

It's not easy, test all the links one by one. In most cases it's true that it's the same name, but a number of cases it's different.

Didn't you have to test them one by one to put them in tests.js? If so, you already have this data. If not, and you just generated them, you don't need to store them either, you can generate them on the fly!

Zefling commented 3 years ago
LeaVerou commented 3 years ago

I passed 3 hours testing them all one by one.

Then we know exactly which ones we can omit, since all of the ones in there now exist :)

Though I'm not sure there's a point in marking any as nonexistent; if a property doesn't have an MDN page today, it may have one tomorrow, and possibly linking to it may encourage that. Note that MDN itself links to nonexistent pages for this very reason.

It would be good to keep the mdn key for those few instances where there is an MDN page, but it's not possible to automatically generate its URL.

PolariTOON commented 3 years ago

Did you look at https://github.com/mdn/data?

It's available as an npm package.

The data includes links to MDN pages for :

Zefling commented 3 years ago

It's interesting, but it also seems complicated to me to implement. What to do with all the exceptions?

LeaVerou commented 3 years ago

Thanks for the commit! It still seems like there's a lot that can be generated though.

Zefling commented 3 years ago

Now, these are just the exceptions. It will be easier to follow.

Zefling commented 3 years ago

I found a solution to generate more links

LeaVerou commented 3 years ago

Why do we need mdnGroup for media queries? Don't we know whether the feature is a media query?

Zefling commented 3 years ago

The 3 firsts tests is not in the group, I create a group for this exception ?

I couldn't find an SVG for the logos, I will draw them.

PolariTOON commented 3 years ago

MDN original logo seems to be here: https://github.com/mdn/mdn-dinocons/blob/master/brands/mdn-dino.svg

Zefling commented 3 years ago

Sorry, I see your message too late for the logo. I redraw this. ^^;

Zefling commented 3 years ago

@LeaVerou Are you ok with all changes?

LeaVerou commented 3 years ago

Just left a small comment about SVG, apart from that LGTM! Thanks for working on this!

Zefling commented 3 years ago

I think all in done now.

LeaVerou commented 3 years ago

Merged, thanks again!!

Zefling commented 3 years ago

@TrisTOON I will fix it