LeaVerou / css3test

How does your browser score for its CSS3 support?
http://css3test.com
MIT License
214 stars 83 forks source link

Add descriptor tests for @counter-style #210

Closed Zefling closed 2 years ago

Zefling commented 3 years ago

I had to make lots of exceptions to be able to test @counter-style completely. I don't know if it can be accepted.

image

LeaVerou commented 3 years ago

thank you for working on this. However, I don't think adding exceptions for specific rules in the testing code is a good way forward. Instead of making exceptions for specific rules, we should add extensibility points so that the tests that need exceptions can define whatever exceptions they need themselves. Otherwise, if in the future we need to make more exceptions, the code will become a mess.

Zefling commented 3 years ago

I changed for rules in tests.js

Zefling commented 3 years ago

@LeaVerou Is it not good ?