search

LeaVerou / css3test

How does your browser score for its CSS3 support?
http://css3test.com
MIT License
214 stars 83 forks source link

Bound properties to values #237

Closed SebastianZ closed 1 year ago

SebastianZ commented 1 year ago

Moved the properties to test the values for to the individual values. This allows to provide different properties for the values.

Fixes #184

Sebastian

SebastianZ commented 1 year ago

This seems extremely repetitive. Why not specify them in the root and override them in individual features if/when needed?

I've answered that in #184.

Sebastian

LeaVerou commented 1 year ago

This seems extremely repetitive. Why not specify them in the root and override them in individual features if/when needed?

I've answered that in #184.

Sebastian

I replied to you there.

SebastianZ commented 1 year ago

@LeaVerou Changed. Please have another look!

Sebastian

LeaVerou commented 1 year ago

Hi there,

I tried to review the diff, but it's very difficult due to the number of unrelated changes included in it. Anyhow, as long as you can still specify properties globally and don't have to repeat them on every single test, I trust you that the changes are fine.

LeaVerou commented 1 year ago

(approved so that any pending comments would be flushed, but I stopped leaving comments after a while because they'd be all "this is unrelated, and this, and this, and this"

SebastianZ commented 1 year ago

I tried to review the diff, but it's very difficult due to the number of unrelated changes included in it.

Ok, let's close this in favor of #238 which only includes changes related to this new feature.

I'll make the unrelated changes separately.

Seastian