LeaVerou / css3test

How does your browser score for its CSS3 support?
http://css3test.com
MIT License
214 stars 83 forks source link

Adding `min/max/fit-content` and `fit-content()` values to `flex-basis` and `flex` #250

Closed yisibl closed 1 week ago

yisibl commented 4 months ago
yisibl commented 4 months ago

@LeaVerou PTAL, thanks!

SebastianZ commented 3 months ago

Btw. regarding the state of the fit-content keyword vs. the fit-content() function, I just filed https://github.com/w3c/csswg-drafts/issues/10601.

Sebastian

yisibl commented 1 week ago

Chrome recently started implementing the stretch keyword, so I've added it to this PR as well.

https://chromium-review.googlesource.com/c/chromium/src/+/5985742

image

yisibl commented 1 week ago

@SebastianZ It makes sense to add separate tests to flex properties to help users more visually see how they are supported in different properties.

SebastianZ commented 1 week ago

@SebastianZ It makes sense to add separate tests to flex properties to help users more visually see how they are supported in different properties.

I'm still not totally happy with this, but given that Chrome explicitly implements it for flex-basis and flex, I guess it's ok.

Though we should ensure the values are also tested in the Box Sizing specs for other properties.

Sebastian