search

LeaVerou / css3test

How does your browser score for its CSS3 support?
http://css3test.com
MIT License
214 stars 83 forks source link

Added emoticons to CSS3Test for monochrome screens #27

Closed stopsatgreen closed 12 years ago

stopsatgreen commented 12 years ago

Testing on an eReader the colours were too hard to tell apart. Have added emoticons to make it easier. Edge case, I know.

LeaVerou commented 12 years ago

Hi,

Thanks for the contribution! I was sure looking for a way to reduce the reliance on color, primarily for colorblind folks. However, I'm concerned that this will create too much visual noise for everyone. Do you have a screenshot of how it looks?

Thanks!

stopsatgreen commented 12 years ago

Sure, it's attached.

I think it looks alright, but it's your call. I did consider using a single unicode character: ✓, ✗and so on, but couldn't think of characters to show the varying degrees of implementation. Another approach may be to use a custom icon set.

From: Lea Verou reply@reply.github.com To: Peter Gasston p_gasston@yahoo.com Sent: Thursday, 26 July 2012, 6:23 Subject: Re: [css3test] Added emoticons to CSS3Test for monochrome screens (#27)

Hi,

Thanks for the contribution! I was sure looking for a way to reduce the reliance on color, primarily for colorblind folks. However, I'm concerned that this will create too much visual noise for everyone. Do you have a screenshot of how it looks?

Thanks!

Reply to this email directly or view it on GitHub: https://github.com/LeaVerou/css3test/pull/27#issuecomment-7269582

LeaVerou commented 12 years ago

Um, I’m afraid nothing is attached. :(

stopsatgreen commented 12 years ago

Darn. Have a look at it online instead: http://broken-links.com/tests/css3test/

From: Lea Verou reply@reply.github.com To: Peter Gasston p_gasston@yahoo.com Sent: Thursday, 26 July 2012, 22:13 Subject: Re: [css3test] Added emoticons to CSS3Test for monochrome screens (#27)

Um, I’m afraid nothing is attached. :(

Reply to this email directly or view it on GitHub: https://github.com/LeaVerou/css3test/pull/27#issuecomment-7290618

LeaVerou commented 12 years ago

They look better than I expected. Could you reduce their opacity and float them right in the sidebar ("Specs tested")? They look quite bad there.

LeaVerou commented 12 years ago

Also, there's no emoticon for .almost-pass. It’s better to have the same as for .pass rather than none.

stopsatgreen commented 12 years ago

I've updated the online preview; have a look and see what you think.

LeaVerou commented 12 years ago

Great! Could you also make the sidebar ones have the same font as the ones in the tests?

Thanks!

stopsatgreen commented 12 years ago

Done.