Closed DmitrySharabin closed 6 months ago
Name | Link |
---|---|
Latest commit | 84f82b7f767752af874b7950bd6efa3d2d04ec2f |
Latest deploy log | https://app.netlify.com/sites/h-test/deploys/6658ed10b0e5ba0008c70e9a |
Deploy Preview | https://deploy-preview-31--h-test.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
So I think it would make sense to code this behavior as the default behavior, and if we get any use cases for a different behavior we can examine what the best API would be for that. We cannot design an API without a good understanding of use cases.
Look at this case I stumbled on today—if we automatically expand all groups with failed tests, we might end up with ruined output. The new failed test on Color.js
is an excellent example.
https://github.com/LeaVerou/htest/assets/9166277/5fec7871-61e8-41b9-aed3-c7939953af66
We probably should also think of the output of a test's results.
While we certainly shouldn't break so badly in that case, I do wonder why that test output there is so long...
This PR was divided into several smaller (already merged) PRs, so we don't need it anymore. I'm going to close it.
This PR addressed issues discussed in #7:
expand
option—groups with failed child tests will be expanded by default