Allow 'max' of 0 and Check 'value' for absence and Update low/high on direct 'value' change.

LeaVerou / multirange

A tiny polyfill for HTML5 multi-handle sliders

http://projects.verou.me/multirange/

MIT License

605 stars 82 forks source link

Allow 'max' of 0 and Check 'value' for absence and Update low/high on direct 'value' change. #24

Closed n00b42 closed 7 years ago

n00b42 commented 7 years ago

1) Until now having a range input with e.g. min=-10 and max=0 lead to unexpected behavior, as max=0 was interpreted as empty and replaced by 100. 2) Although an empty 'value' was already taken care of ("values[0] || ...") 3) While changing the value directly using JS was possible, the graphical representation did not update correctly (only on user interaction).

n00b42 commented 7 years ago

This is my first pull request ever, I hope its ok that way. I did not now if I should have split the 3 commits in different requests or bundle them...

n00b42 commented 7 years ago

Incorporated your suggestions.

LeaVerou commented 7 years ago

Merged, thanks!

I’m honored that you chose this project for your first PR! I hope this will be the start of many more contributions to open source projects! 😄