search

LeafCutterLabs / bigKNOB

Macropad Media Controrller with QMK + USC-C + RGB underglow + Hotswaps
53 stars 12 forks source link

Reverse direction of volume up/down on bigKNOBv2 #1

Closed loganmarchione closed 4 years ago

loganmarchione commented 4 years ago

I just purchased the bigKNOBv2 and noticed the direction of volume up/down on the knob was reversed.

In my mind, turning the knob clockwise should be "volume up" and counter-clockwise is "volume down" (like the image below).
https://cdn3.vectorstock.com/i/1000x1000/60/12/volume-button-knob-vector-1866012.jpg

The code would seem to suggest this is correct, but it's backwards. I switched lines 8 and 10 in this file and it seems to be "right" to me. Can you confirm?
https://github.com/LeafCutterLabs/bigKNOB/blob/master/Software/QMKv2/keymaps/default/keymap.c

LeafCutterLabs commented 4 years ago

That is correct but depends on the brand of encoder (Alps is different than Bourns).

On Wed, Jun 24, 2020 at 12:50 PM Logan Marchione notifications@github.com wrote:

I just purchased the bigKNOBv2 and noticed the direction of volume up/down on the knob was reversed.

In my mind, turning the knob clockwise should be "volume up" and counter-clockwise is "volume down" (like the image below).

https://cdn3.vectorstock.com/i/1000x1000/60/12/volume-button-knob-vector-1866012.jpg

The code would seem to suggest this is correct, but it's backwards. I switched lines 8 and 10 in this file and it seems to be "right" to me. Can you confirm?

https://github.com/LeafCutterLabs/bigKNOB/blob/master/Software/QMKv2/keymaps/default/keymap.c

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LeafCutterLabs/bigKNOB/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRHDXX5WELBEMKQVPSTTRLRYJKJRANCNFSM4OHFL7OA .

loganmarchione commented 4 years ago

Got it, thanks!