Leaflet / Leaflet.Editable

Make geometries editable in Leaflet.
http://leaflet.github.io/Leaflet.Editable/doc/api.html
559 stars 197 forks source link

Can't create marker or polyline on Chrome for Android #146

Closed opoto closed 6 years ago

opoto commented 7 years ago

I don't know about the root cause, but I noticed Leaflet.Editable does not work properly anymore on Chrome for Android. To reproduce:

opoto commented 7 years ago

I tried to have a look at the code, but it is beyond my competencies. Does anybody have any hint on what is going wrong? This completely breaks apps using this plugin on Android/Chrome. Thanks

Gjum commented 7 years ago

This is also reproducible using Chrome DevTools, with device emulation enabled (second icon in the top left).

Did you find out between which versions this broke? It's affecting my site as well and I'll have to consider downgrading until this is fixed.

As for what's going wrong, my wild guess is that there are different events (touch?) being emitted on mobile.

willemx commented 7 years ago

Can confirm this issue on Chrome for Windows on a Microsoft Surface Pro 4.

opoto commented 7 years ago

Actually it doesn't seem to be specific to Leaflet.Editable: I see there is the same issue with Leaflet.PM. This is probably an issue in Leaflet itself (or in Chrome, but might be tricky to get it fixed there...).

Gjum commented 7 years ago

possibly related to https://github.com/Leaflet/Leaflet/issues/5646?

opoto commented 7 years ago

Yes, this looks to be the cause of the issue! Thanks for spotting it.

chocho11 commented 6 years ago

right, leaflet editable doesnt work on android-chrome : cannot create marker/polyline/polygon ! In Apple (iphone and ipad) does it work ?

opoto commented 6 years ago

Yes, works fine on Safari for iOS. As well as on Firefox, Samsung browser, Chrome on Windows... Just failing on Chrome/Android

willemx commented 6 years ago

@opoto : Chrome for Windows does not work for me on a Microsoft Surface Pro 4...

opoto commented 6 years ago

Following various upgrades (Android, Chrome, Leaflet, Leaflet.Editable...) it works now. So I'm closing this ticket