Leaflet / Leaflet.VectorGrid

Display gridded vector data (sliced GeoJSON or protobuf vector tiles) in Leaflet 1.0.0
598 stars 194 forks source link

Allow multiple features per ID per tile #132

Closed brendan-ward closed 5 years ago

brendan-ward commented 6 years ago

Like #65, I was running into a case where only some features were getting updated with setFeatureStyle and resetFeatureStyle.

The underlying reason is addressed in this PR: there are multiple features that have the same ID in a given tile, but only the last encountered was stored with that ID (in renderer._features[id]).

I changed this to allow an array instead of a single feature and updated setFeatureStyle and resetFeatureStyle to use this. It fixed my particular case.

(not sure what is going on here with whitespace, it looks right in my editor. Sorry for any formatting issues)

zogs commented 6 years ago

This fix solved my problem as well, this should be reviewed and added to future release.

brendan-ward commented 5 years ago

This is ready for re-review (conflicts against master now resolved).