search

Leaflet / Leaflet.VectorGrid

Display gridded vector data (sliced GeoJSON or protobuf vector tiles) in Leaflet 1.0.0
606 stars 194 forks source link

remove demo line from gobblefile.js #86

Closed kelvinabrokwa closed 7 years ago

kelvinabrokwa commented 7 years ago

Since the demo directory no longer exists, the line I removed prevents gobble from running (so npm start simply errors)

~Edit: Also fixes a clickHandler bug that uses the non-existent L.DomEvent.fakeStop instead of L.DomEvent._fakeStop(e)~

IvanSanchez commented 7 years ago

It's weird that Gobble is having problems with that. As far as I'm aware, if a node is not part of the final tree, it will not start watching the files. Anyway that's a good cleanup :+1:

However, I must complain about the fakeStop change. (See https://github.com/Leaflet/Leaflet.VectorGrid/issues/81).

We follow a "one feature per pull request" unwritten rule here, so I must ask you to either split this, or solve #81 in a better way.

kelvinabrokwa commented 7 years ago

@IvanSanchez ok I removed the fakeStop change

IvanSanchez commented 7 years ago

Nice :+1:

kelvinabrokwa commented 7 years ago

@IvanSanchez dope, thanks 😄