Error of the line creating possibility consisting of one point - Githubissues

Leaflet / Leaflet.draw

Vector drawing and editing plugin for Leaflet

https://leaflet.github.io/Leaflet.draw/docs/leaflet-draw-latest.html

MIT License

1.98k stars 994 forks source link

Error of the line creating possibility consisting of one point #1019

Open dmmishchenko opened 3 years ago

dmmishchenko commented 3 years ago

[X] I'm reporting a bug, not asking for help
[ ] I've looked at the documentation to make sure the behaviour is documented and expected
[X] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[X] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.7.0
Leaflet Draw version I'm using: 1.0.3
Browser (with version) I'm using: 90.0.4430.93
OS/Platform (with version) I'm using: Windows 10

Steps:

Enable polyline drawing:
Start drawing polyline
add one point
after adding one point, click on it
draw:created event fired

I found this at line 233:

_shapeIsValid: function () {
    return true;
},

I think there must be something like this:

_shapeIsValid(): boolean {
    return this._markers.length >= 2;
},

we also need to add handling for this error, since the current error message is not valid

What behaviour I'm expecting and which behaviour I'm seeing

Minimal example reproducing the issue

[X] this example is as simple as possible
[X] this example does not rely on any third party code

Demo: https://jsfiddle.net/dmmishchenko/gmnk1a0f/10/