polygon and line not working with leaflet 1.0.0+

jignesh-techvasu commented 7 years ago

[X] I'm reporting a bug, not asking for help
[X] I've looked at the documentation to make sure the behaviour is documented and expected
[X] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[X] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.0.1
Leaflet Draw version I'm using: 0.4.2
Browser (with version) I'm using: Chrome 55
OS/Platform (with version) I'm using: Windows
None of my code. Just open current leaflet live demo page : https://leaflet.github.io/Leaflet.draw/docs/examples/full.html
Click on line icon to draw line.
Add 2-3 points and try to click on last point to complete the drawing
You will notice drawing doesn't get finished
Try to draw polygon same way now
You wont be able to finish polygon by clicking on first point.

What behaviour I'm expecting and which behaviour I'm seeing

User should be able to finish polyline by clicking on last point. Same way, user should be able to finish polygon by clicking on first point.

Minimal example reproducing the issue

[x] this example is as simple as possible
[X] this example does not rely on any third party code

No need for anything else as issue is reproducible on leafdraw demo page itself.

mike-unearth commented 7 years ago

This will be fixed with this pull request: https://github.com/Leaflet/Leaflet.draw/pull/657

jignesh-techvasu commented 7 years ago

@mike-unearth : That's great!.. Thank you.

jignesh-techvasu commented 7 years ago

@mike-unearth : Any idea about merge schedule for this pull? I am actually counting on it :)

mike-unearth commented 7 years ago

It was merged today actually! Try version 0.4.8.

jignesh-techvasu commented 7 years ago

@mike-unearth : Great!... Thank you.

chiccorusso commented 7 years ago

Hi. I'm having the same problem. The update to 0.4.8 solved the missed clic on the last point, but the problem persists when I try to finish a polyline (or a polygon) using the "Finish" button. In that case a last point is added to the polyline, and then the the "Finish" button is clicked.

antea_palladio_web_-_sewer

The same thing happens with the "Delete last point" button: a new point is added, and is immediately deleted.

vladimirbuskin commented 7 years ago

@chiccorusso hello, that pull request https://github.com/Leaflet/Leaflet.draw/pull/658 should make it work

ddproxy commented 7 years ago

@chiccorusso PR's have been merged to resolve this issue.

chiccorusso commented 7 years ago

Thank-you! It's working.

Leaflet / Leaflet.draw