Editing CircleMarker no longer possible using Leaflet 1.x - Githubissues

Leaflet / Leaflet.draw

Vector drawing and editing plugin for Leaflet

https://leaflet.github.io/Leaflet.draw/docs/leaflet-draw-latest.html

MIT License

1.98k stars 994 forks source link

Editing CircleMarker no longer possible using Leaflet 1.x #714

Open v1r0x opened 7 years ago

v1r0x commented 7 years ago

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.0.3
Leaflet Draw version I'm using: 0.4.9
Browser (with version) I'm using: Firefox 53.0 (Beta 10), Chromium 57.0.2987.98
OS/Platform (with version) I'm using: Ubuntu LTS 16.04
Add CircleMarker
Click on Edit

What behaviour I'm expecting and which behaviour I'm seeing

Expecting:

Layers should be editable

Seeing:

Results in TypeError: layer.editing is undefined (Firefox) or Uncaught TypeError: Cannot read property 'enable' of undefined (Chromium)

Minimal example reproducing the issue

[x] this example is as simple as possible
[x] this example does not rely on any third party code

Using jsfiddle.

Possible Reason

CircleMarker is no longer inheriting from Circle in leaflet 1.x. Instead Circleis now inheriting from CircleMarker. Editing options are added to Circle in Leaflet.draw and are thus not available for CircleMarker.

fpuga commented 7 years ago

We are also experimenting this issue and we implemented a patch. Check if this works for you (download the repo and build the dist with ./node_modules/.bin/jake build)