Panning the map in draw mode adds node into my polyline/polygon

doubotis commented 7 years ago

[X] I'm reporting a bug, not asking for help
[X] I've looked at the documentation to make sure the behaviour is documented and expected
[X] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[X] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.0.3
Leaflet Draw version I'm using: 0.4.9+
Browser (with version) I'm using: Chrome 58.0.3029.110
OS/Platform (with version) I'm using: Mac/PC

What behaviour I'm expecting and which behaviour I'm seeing

Expecting: When panning the map in draw mode, no nodes are added in my polyline.
Seeing: When panning the map in draw mode, a node is added to my polyline at the position I start panning.

Minimal example reproducing the issue

Try to pan the map when in drawing mode. Your example: http://leaflet.github.io/Leaflet.draw/docs/examples/full.html

Old version, expected behavior: https://jsfiddle.net/user2314737/Lscupxqp/

Additional information

This behavior was not observed in previous versions (with Leaflet 1.0.0 / L.Draw 0.2.3 it seems to work well)

I've searching in the code and it appears touchstart event is called before mouse events. That means mouseup/mousedown events are "ignored". Well, okay, but why touchstart event triggers the adding of a node? The node must be added when touchend triggers, not before.

I tried to add a "touchend" event on the map, but seems that doesn't work. map.on("touchend touchcancel", function(e) { console.log(e); }); doesn't log anything.

Maybe an issue with Leaflet itself ?

TheVoxell commented 7 years ago

Same issue here :)

federicoalvarez-github commented 7 years ago

same here

goflo commented 7 years ago

I have the same issue. There is already an issue for that: https://github.com/Leaflet/Leaflet.draw/issues/695 There is also an workaround (overriding the L.Draw.Polyline.prototype._onTouch) included which works fine for me.

johnd0e commented 4 years ago

Possible fix: https://github.com/Leaflet/Leaflet.draw/issues/935#issuecomment-577151194

Leaflet / Leaflet.draw