Dragging the resizing marker cannot change the circle's size

ahua52 commented 6 years ago

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[ ] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.0.3
Leaflet Draw version I'm using: 0.4.13
Browser (with version) I'm using: Chrome 62.0.3202.94 (Official Build) (64-bit)
OS/Platform (with version) I'm using: OS X EI Capiton
Draw a circle;
Click on edit button;
Resize the circle by dragging the square marker;

What behaviour I'm expecting and which behaviour I'm seeing

I'm expecting that dragging the marker should change the circle's size. What I see is that the editing markers are moving, but the circle size is not changed.

Minimal example reproducing the issue

[x] this example is as simple as possible
[x] this example does not rely on any third party code

Using plunker.

kitzilla commented 6 years ago

I have crashed into the same issue (Leaflet 1.2.0, Leaflet-draw 0.4.13 downloaded with npm)

As a meantime solution, I have patched a minified js in the following way and circle radius now follows the handler for me.

Open node_modules/leaflet-draw/dist/leaflet.draw.js in text editor
Find the following string in the file, there should be only one match radius=this._map.distance(e,t),this._map.fire(L.Draw.Event.EDITRESIZE
Replace this part with radius=this._map.distance(e,t),this._shape.setRadius(radius),this._map.fire(L.Draw.Event.EDITRESIZE

If you are using leaflet.draw-src.js, I think you want to add this._shape.setRadius(radius) to line 2743 If you are building from source, I think you want to add this._shape.setRadius(radius) to line 33 of Edit.Circle.js

Hope this helps

mdomnita commented 6 years ago

I have the same issue with the leaflet-draw from npm. This solution works fine, thanks for it @kitzilla

Leaflet / Leaflet.draw