Cannot read property 'updateContent' of undefined

joshkopecek commented 6 years ago

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.2.0
Leaflet Draw version I'm using: 1.0.0
Browser (with version) I'm using: Chrome 63.0.3239.132
OS/Platform (with version) I'm using: macOS 10.13.2
1. Set up a map with Leaflet + Leaflet.draw
2. Set up a circle in drawnItems
3. Manually enable editing (not using the toolbar)
4. Try to resize it

What behaviour I'm expecting and which behaviour I'm seeing

Should be able to manually edit shapes (I control the editing behaviour so users can only edit one shape at a time), but get this updateContent error

Minimal example reproducing the issue

[x] this example is as simple as possible
[x] this example does not rely on any third party code

This jsfiddle reproduces the problem faithfully. Check the console log for the error - it's due to line 35 in this file. The problem here is that _editTooltip hasn't been set up because noone clicked the pencil 'edit' button in the toolbar, since the edit state is triggered manually. A simple if (this._map.hasOwnProperty('_editTooltip')) {… here would fix this, but I don't know if you want to cater for this eventuality?

joshkopecek commented 6 years ago

FYI I made a temporary fix by adding this hack to the setup

map._editTooltip = {
    updateContent: foo => null
}

ddproxy commented 6 years ago

@joshkopecek Thank you for this issue, as you've pointed out - it's not a normal process to trigger editing a geometry programatically. However, this is a valid bug. 1.0.1 has been release to check for the tooltip before attempting to modify it. Let me know if that resolves the issue :)

joshkopecek commented 6 years ago

@ddproxy I've been using this for a while - it's very useful functionality for me to be able to enable/disable editing on individual shapes.

Huge thanks for the commit. Much appreciated, I can take my ugly hack out now :-)

The examples for edit handlers makes use of this this functionality, although that example shows a Uncaught TypeError: Cannot read property 'className' of undefined

ddproxy commented 6 years ago

I also enable/disable editing programmatically. I ended up maintaining this package because I got a bit too close to the source. While it's not complete, there's a fancy rewrite using Leaflet.Editable over in the 2.0.0-fork branch that is aiming at being more friendly for plugins (and this type of use).

Leaflet / Leaflet.draw