Can draw crossed polygon with allowIntersection set to false - Githubissues

Leaflet / Leaflet.draw

Vector drawing and editing plugin for Leaflet

https://leaflet.github.io/Leaflet.draw/docs/leaflet-draw-latest.html

MIT License

1.97k stars 992 forks source link

Can draw crossed polygon with allowIntersection set to false #823

Open hbaltz opened 6 years ago

hbaltz commented 6 years ago

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.2.0
Leaflet Draw version I'm using: 0.4.13
Browser (with version) I'm using: Firefox Quantum v57.0.4 (64bits)
OS/Platform (with version) I'm using: Wintdows 10 professional v1709

Dont' allow intersection for the polygons:

new L.Control.Draw({
  draw: {
    polygon: {
      allowIntersection: false 
    }
  }
}).addTo(map);

Draw a polygon with enough points to create a crossed polygon:

What behaviour I'm expecting and which behaviour I'm seeing

I'm expecting to not be allow to create a crossed polygon when I set allowIntersection to false
I'm seing crossed polygon

Minimal example reproducing the issue

You can reproduce this in the demo

[x] this example is as simple as possible

kirantpatil commented 5 years ago

We also want to detect one more scenario as below.

Create a polygon p1.
Try to create p2 polygon on top of p1

Expected output:

It should show pop like "You are creating polygon on top of existing polygon" to continue Press "Yes" or "No".

If we select "Yes" then it should allow us to draw overlapping polygon and if "No" then it should discard the last step of polygon so that he can still proceed to create polygon p2 without intercepting the p1.