PolyLine _endPoint issue - Githubissues

Leaflet / Leaflet.draw

Vector drawing and editing plugin for Leaflet

https://leaflet.github.io/Leaflet.draw/docs/leaflet-draw-latest.html

MIT License

1.96k stars 992 forks source link

PolyLine _endPoint issue #962

Open isak-glans opened 4 years ago

isak-glans commented 4 years ago

[X ] I'm reporting a bug, not asking for help
[X ] I've looked at the documentation to make sure the behaviour is documented and expected
[ X] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[ X] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.5.1
Leaflet Draw version I'm using: 1.0.4
Browser (with version) I'm using: Chrome v. 77.0.3865.90
OS/Platform (with version) I'm using: Windows 10

What behaviour I'm expecting and which behaviour I'm seeing

It won't end the polyLine but add another marker.

Minimal example reproducing the issue

Look at demo example in http://leaflet.github.io/Leaflet.draw/docs/examples/full.html.
Open the Draw.PolyLine.js file and goto the _endPoint method.
Change "else if (lastPtDistance < 10 && L.Browser.touch ) {" too : "else if (lastPtDistance < 10 && L.Browser.touch == false) {"
Draw a polyLine and try to finish it by clicking on the last marker.

johnd0e commented 4 years ago

Duplicate of #963 and other similar issues. Fix is here: https://github.com/Leaflet/Leaflet.draw/issues/935#issuecomment-577151194