Leaflet / Leaflet.draw

Vector drawing and editing plugin for Leaflet
https://leaflet.github.io/Leaflet.draw/docs/leaflet-draw-latest.html
MIT License
1.98k stars 994 forks source link

"TODO: perhaps if not set then all layers on the map are selectable?" #990

Open Pointotech opened 4 years ago

Pointotech commented 4 years ago

How to reproduce

What behaviour I'm expecting and which behaviour I'm seeing

In EditToobar.js, on line 28: https://github.com/Leaflet/Leaflet.draw/blob/d5dd11781c2e07f9e719308e504fe579000edf54/src/edit/EditToolbar.js#L28

The comment says: REQUIRED! TODO: perhaps if not set then all layers on the map are selectable?

Do we know if this is still something to be done? If this is a bug, or an edge case that needs to be handled, or a new feature that's being developed, can someone describe it?

If it's no longer relevant, can we remove it?

I'll gladly raise a pull request to address this either way, if I have requirements.

Thank you :)

Minimal example reproducing the issue

https://github.com/Leaflet/Leaflet.draw/blob/d5dd11781c2e07f9e719308e504fe579000edf54/src/edit/EditToolbar.js#L28

I found one more TODO comment which has a similar issue: