Rework Legacy PNG Icons with Font Awesome SVG - Githubissues

Leaflet / Leaflet.fullscreen

A fullscreen control for Leaflet

http://leaflet.github.io/Leaflet.fullscreen/

ISC License

436 stars 117 forks source link

Rework Legacy PNG Icons with Font Awesome SVG #118

Open hswong3i opened 2 years ago

hswong3i commented 2 years ago

Existing implementation handle icon with PNG, with manual positioning with CSS background image.

This PR rework icons with Font Awesome SVG:

Locally venor Font Awesome v5.15.4 expand-solid.svg and compress-solid.svg
Rework styling with SCSS
Fix accessibility (see #110)
Test with Leaflet v1.7.1
Update demo with above changes

Fix #98 Fix #102 Fix #103 Fix #110 Fix #114

Online demo: https://drustack.github.io/Leaflet-Leaflet.fullscreen/

Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com

runette commented 2 years ago

Unfortunately - no one with access to merge PRs seems to be looking at this repo.

If you want to see a fork with all of the PRs added (including this one) - see https://github.com/runette/Leaflet.fullscreen and the npm package as below (version 1.0.6 includes this PR) :

https://www.npmjs.com/package/@runette/leaflet-fullscreen