search

Leaflet / Leaflet.fullscreen

A fullscreen control for Leaflet
http://leaflet.github.io/Leaflet.fullscreen/
ISC License
436 stars 117 forks source link

demo page broken #38

Closed letmaik closed 9 years ago

letmaik commented 9 years ago

Tested in Firefox.

yohanboniface commented 9 years ago

Are you talking about http://leaflet.github.io/Leaflet.fullscreen/ ? It seems to work without issue here (Firefox 38, Ubuntu 15.04). Can you be a bit more specific on what's broken?

Eschon commented 9 years ago

@neothemachine I think you confused this repository with brunob/leaflet.fullscreen because their demo page really seems to be broken.

Edit: I just saw that you also opened an issue over there, did you have any problem with this repositories demo page? It works fine for me in Safari.

letmaik commented 9 years ago

It happens when I access it via https: https://leaflet.github.io/Leaflet.fullscreen/ I just realized that the HTTPS Everywhere browser plugin is doing the automatic switch from http to https. It seems that the leafletjs cdn has an invalid SSL certificate, otherwise it would be as simple as leaving off the protocol when including leaflet in your html: //cdn.leafletjs.com/leaflet-0.7.3/leaflet.js Any ideas?

On 06/07/2015 08:58, Yohan Boniface wrote:

Are you talking about http://leaflet.github.io/Leaflet.fullscreen/ ? It seems to work without issue here (Firefox 38, Ubuntu 15.04). Can you be a bit more specific on what's broken?

— Reply to this email directly or view it on GitHub https://github.com/Leaflet/Leaflet.fullscreen/issues/38#issuecomment-118763168.

Eschon commented 9 years ago

True, with https it works for me in latest Safari but is broken in FF38.

letmaik commented 9 years ago

Here's the SSL issue: https://github.com/Leaflet/Leaflet/issues/1824 Well, I guess a possible solution would be to just use the cloudflare cdn since it supports https: //cdnjs.cloudflare.com/ajax/libs/leaflet/0.7.3/leaflet.js Ideally though leaflets cdn host should support https which actually seems possible according to http://webmasters.stackexchange.com/a/30060

jfirebaugh commented 9 years ago

Closing here since the issue is with SSL / HTTPS Everywhere. I've reopened https://github.com/Leaflet/Leaflet/issues/1824 since it should be possible to provide https support on the CDN now.