search

Leaflet / Leaflet.label

Leaflet.label is plugin for adding labels to markers & shapes on leaflet powered maps.
MIT License
465 stars 225 forks source link

Labels don't show on Leaflet 1.0b1 #121

Open trakais opened 9 years ago

trakais commented 9 years ago

@Leaflet says this plugin needs update to be supported in Leaflet 1

snkashis commented 9 years ago

I have a preliminary b1 branch up @ https://github.com/Leaflet/Leaflet.label/compare/master...snkashis:b1_compat . What problems are you seeing so far? I do see labels falling below polygons.

snkashis commented 9 years ago

Took care of that with a z-index bump up to 500.

snkashis commented 9 years ago

And yeah, I see how there is an issue with whenReady callback on L.map.

snkashis commented 9 years ago

2.2-dev appears to be fine with b1... because of https://github.com/Leaflet/Leaflet.label/commit/cead0a63afb195ce842536fe3ba92ebcb5f90188

danzel commented 9 years ago

From testing locally we needed to always redraw on viewreset. I've pushed up a branch here: https://github.com/Leaflet/Leaflet.label/tree/leaflet-master

yohanboniface commented 9 years ago

@danzel I see you have started a branch for 1.0 compat, what about pulling out #122 on there too?

danzel commented 9 years ago

Thanks, hadn't seen that one, will do and tidy up.

benglass commented 9 years ago

great library!

:+1: any progress on a stable release or consolidated branch for leaflet 1 support?

a1an77 commented 8 years ago

Same problem here with 1.0b2, how can I hotfix it until a release comes? Thanks

danzel commented 8 years ago

use the leaflet-master branch, you'll need to build the js yourself.

Run npm install and then jake (iirc)

PikachuEXE commented 8 years ago

The bower.json on that branch seems not updated yet

smitchell commented 8 years ago

I just tried the preliminary branch with Leaflet hotline, and when I pulled it L.hotline was undefined. Not sure whats up with that. http://exploringspatial.com/#demo/10 I've removed Label from the demo for now.

plmarko commented 8 years ago

Hi,

The issue with whenReady callback on L.map. still exists if you get package using npm install leaflet-label. I've seen the fix in the cead0a6 but probably you forgot to bump up the version with this fix . Ver 0.2.2-dev on npm still has some old code.