search

Leaflet / Leaflet

🍃 JavaScript library for mobile-friendly interactive maps 🇺🇦
https://leafletjs.com
BSD 2-Clause "Simplified" License
40.28k stars 5.76k forks source link

Get rif of prefixed `requestAnimationFrame` leftovers #9241

Closed mourner closed 4 months ago

mourner commented 4 months ago

Well, this is pretty weird — I don't know why this would fail CI so much.

mourner commented 4 months ago

This seems to work https://github.com/Leaflet/Leaflet/tree/cleanup-raf-leftovers-2 — really can't comprehend what's wrong with the current changes though.

jonkoops commented 4 months ago

@mourner I had this exact same issue when I tried to clean up the RAF code. It seems to have something to do with how the test suite handles the RAF functions, as it does actually function in manual testing.

mourner commented 4 months ago

@jonkoops put the variables back and it works (no idea why though) — ready for review now.