Layers with animated coordinates shift incorrectly when zooming

FeldrinH commented 3 months ago

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce

Create a CircleMarker, Polyline or other similar layer and then change its coordinates. Try zooming in and out while the coordinates change.

Expected behavior

The layer stays in its place.

Current behavior

The layer briefly jumps to an incorrect location while the zoom animation is ongoing. Layers where the coordinates are not actively changed behave correctly and stay in place.

Note: The issue seems to happen with both the canvas and SVG renderer.

Minimal example reproducing the issue

https://plnkr.co/edit/Ezv0b0skouMOfZXZ?preview

https://github.com/Leaflet/Leaflet/assets/5256211/0ed10dd2-d9e3-41d1-b710-cbb02a93512e

Environment

Leaflet version: 1.9.4
Browser (with version): Chrome 125.0.6422.142, Firefox 127.0
OS/Platform (with version): Windows 10

FeldrinH commented 3 months ago

It appears that this is a partial regression. In older Leaflet versions the zooming of moving vector layers was working correctly with scrollwheel zoom, but had the same issue that it has now on mobile with pinch zoom (going back to Leaflet 1.0.0 I could not find a version where pinch zoom worked correctly with moving vector layers).

With some local testing I determined that the first commit where scrollwheel zoom has issues with vector layers is https://github.com/Leaflet/Leaflet/commit/48a38c797b19cefb28002f7d09199d947260106a, which was introduced in PR https://github.com/Leaflet/Leaflet/pull/7967.

@Falke-Design since you are the original author of that PR, do you have any insight on this issue?

N1ve5h commented 3 months ago

@FeldrinH I have a workaround for the issue. What I did what stop the interval when zoom animation starts and start the interval when the zoom animation ends. Example

Leaflet / Leaflet