search

Leafwing-Studios / leafwing_input_playback

Input capture and playback functionality for the Bevy game engine.
Apache License 2.0
30 stars 5 forks source link

Remove FrameCount in favor of Bevy counterpart #38

Closed snendev closed 2 months ago

snendev commented 2 months ago

Issues

Fixes https://github.com/Leafwing-Studios/leafwing_input_playback/issues/29 - Use built-in frame count

Changes

Notes

Previous FrameCount implementation uses saturating_ add/sub operations, but based on the documentation for FrameCount, it seems that wrapping_ would be more appropriate. I changed any + operators to use wrapping_ functions to be specific for now.

Also, let me know if I have removed any intended effects of the playback tests. I tried to reflect the original intent to the best of my ability.

snendev commented 2 months ago

@alice-i-cecile I don't see a CHANGELOG.md in this project. Would you like me to start one, or should I draft my notes in RELEASES.md for a future release?

snendev commented 2 months ago

Also, thanks for jumping in to help out! Sorry for the random burst of noise from my end!

alice-i-cecile commented 2 months ago

Ah sorry, I meant RELEASES.md! And no worries at all; it's very welcome.

snendev commented 2 months ago

OK -- I added a section for v0.6 and included release notes for this PR and #37 since I didn't follow suit there

alice-i-cecile commented 2 months ago

Awesome. Ping me on Discord when you think that we're ready for the release of 0.6?