search

Leagify / prospect-scraper-dt2021

Scraping draft prospects for fun and charts.
1 stars 9 forks source link

added few unit tests #24

Closed jeromechrist closed 4 years ago

jeromechrist commented 4 years ago

20

added few unit tests for functions in MockDraftPick

robsmithw commented 4 years ago

Just a small comment on this I would modify the hard coded state name and city/state abrev names into constants. This does two things:

  1. Make it easier to modify the test in the future
  2. You can reuse the same state and/or city state abrev for future test that are developed.

It was a super small change, but I did a PR into your forked branch if you want to merge and update, totally up to you though. PR: https://github.com/jeromechrist/prospect-scraper-dt2021/pull/1

jeromechrist commented 4 years ago

hello, yes sure ! I've updated the branch