Refactor List from CSV mapper into its own method

Leagify / prospect-scraper-dt2021

Scraping draft prospects for fun and charts.

1 stars 9 forks source link

Refactor List from CSV mapper into its own method #30

Closed Rollerss closed 4 years ago

Rollerss commented 4 years ago

Hello,

I was able to refactor the ten StreamReader into its own method, where it takes an generic class and generic class map, used to convent the CSV files into list. All current test pass.

Rollerss commented 4 years ago

Hello, I was wondering if there was a reason this pull request has not been merge? Please let me know if you have any questions.

zo0o0ot commented 4 years ago

There are four pending PRs in this repo, and two of them currently have changes requested. Several of them involve refactoring, so I'm taking it slow to make sure I'm not creating a lot of merge conflicts by accepting pull requests before those changes come through.

Christian-Oleson commented 4 years ago

@Rollerss , Looks like there are some merge conflicts that need resolved

Rollerss commented 4 years ago

Hello I am going to close the PR because the methods I was refactoring changed files in PR #29. I can submit a new PR with my suggested refactors.

zo0o0ot commented 4 years ago

👍