search

Leagify / prospect-scraper-dt2021

Scraping draft prospects for fun and charts.
1 stars 9 forks source link

Add github action to build and run tests #34

Closed zo0o0ot closed 4 years ago

zo0o0ot commented 4 years ago

I recently opened the project in GitPod and some of the stuff failed. It would be nice to check if the project builds in Linux and can run tests in Linux.

robsmithw commented 4 years ago

I can tackle this pretty soon if you wanna throw this to me, I had it building and running test on another branch with github actions, but the upgrade to target .NET 5 kinda messed it up so I'll have to look at it a little bit more.

zo0o0ot commented 4 years ago

I know the build failed for me after the .NET 5 upgrade because the project name references had been put into PascalCase even though the file names were in camelCase. I think that probably works in Windows and blows up in Linux. I fixed it in #35, but it would have been nice to catch before I merged the original commit that broke it.

robsmithw commented 4 years ago

Definitely agree there!

robsmithw commented 4 years ago

Right now getting this error: Error: /home/runner/work/prospect-scraper-dt2021/prospect-scraper-dt2021/test/prospectScraperTest/ProgramTest.cs(33,50): error CS0117: 'Program' does not contain a definition for 'FormatDraftDate' [/home/runner/work/prospect-scraper-dt2021/prospect-scraper-dt2021/test/prospectScraperTest/ProspectScraperTest.csproj] Seems like a method might've been renamed to something else, trying to look through and see what it was changed to unless you know off hand?

zo0o0ot commented 4 years ago

Handled in #36