League-of-Fabulous-Developers / FoundryVTT-Fabula-Ultima

Enter Project FU: an unofficial foundry system for Fabula Ultima, channeling the essence of the book while delivering the immersive experience of playing a JRPG in tabletop format.
MIT License
40 stars 18 forks source link

Correct attributes for spells not being assigned for display #143

Closed 4m2c4bl3 closed 2 months ago

4m2c4bl3 commented 2 months ago

When assigning attributes there seem to be two places the values can be set. in FUItem.system.accuracy.attributes.(primary|secondary), and also in FuItem.system.rollInfo.attributes.(primary|secondary).

The value from the dropdown selection correctly is assigned to the rollInfo, so the spell works while rolling. But the values in accuracy don't seem to be properly set, so the display of what attributes are selected is incorrect in the character info.

I don't know why there are two places it can be found, but I assume if you just change attackAttributes in getSpellDisplayData to use the data from rollInfo it will be solved?

image image image

spyrella commented 2 months ago

image My bad, Spells uses check.primary = item.system.rollInfo.attributes.primary.value; check.secondary = item.system.rollInfo.attributes.secondary.value;

Weapons uses check.primary = item.system.attributes.primary.value; check.secondary = item.system.attributes.secondary.value;

Fixed the display issue, it should roll and display the correct die in the next alpha release

4m2c4bl3 commented 2 months ago

thank you!