search

League-of-Fabulous-Developers / FoundryVTT-Fabula-Ultima

Enter Project FU: an unofficial foundry system for Fabula Ultima, channeling the essence of the book while delivering the immersive experience of playing a JRPG in tabletop format.
MIT License
40 stars 18 forks source link

Fix: Twin Shield Tweaks #152

Closed MattByName closed 2 months ago

MattByName commented 2 months ago

Hi there,

I made some tweaks to the Guardian Twin Shields ability as the book says that 'you gain the benefits of both items' (197) but in the compendium the bonus was only being applied once. I also added a Twin Shields item for when the player has one runic and one bronze shield

Changes

Sorry if I've misunderstood the conventions on how you're building items. Thanks for all your hard work, the system is looking great.

MattByName commented 2 months ago

I just noticed I didn't update the uuid inside the new item json, and only put it in the filename. I'm not sure what the best way to generate an id is, I just made one in foundry by creating a copy of one of the other items. Will that cause problems?

spyrella commented 2 months ago

No worries, i just generated a new id and edited the id in the json.

Christopher-R-Perkins commented 2 months ago

I thought the idea was that you would have the twin shields item only replace one of the shields ands still have the other equipped on your offhand.

fultimator-official commented 2 months ago

I thought the idea was that you would have the twin shields item only replace one of the shields ands still have the other equipped on your offhand.

I guess the issue with this is that twin shield counts as a two handed weapon so it’ll take up both main and off hand. I’m holding off doing anything with shields until the equipment system is overhauled, where equipment data is stored in the actor instead of items. From there we could work on equipment validation.

Maybe adding a checkbox that’ll allow you to equip two handed weapons in one slot. So you could equip another shield and gain their benefits.

spyrella commented 2 months ago

To update everyone, in V2.4.0, with the new implementation of EquipmentHandlerV2, the other twin shields wouldn't be necessary anymore since you can now equip two shields and also equip the twin shield item into a "phantom slot". image

Thanks for the help, though!